-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/13/2015 12:27 AM, brian m. carlson wrote: > On Fri, Jun 12, 2015 at 03:14:25PM -0700, Junio C Hamano wrote: >> "brian m. carlson" <sand...@crustytoothpaste.net> writes: >> >>> While I did run the tests between each commit, I hadn't noticed >>> they were failing because I don't have Apache installed on my >>> laptop, so they were silently skipped. I'll resubmit with that >>> fixed. >> >> It is somewhat strange that _only_ http part had failures like >> this, and is unnerving, too, given that a few people seem to have >> given at least a cursory read over the patches and didn't spot >> anything obviously wrong. >> >> Was that because there was a single manual botch, or was that >> merely that other parts of the system do not have sufficient test >> coverage? > > It appears that I broke the change in "parse_fetch: convert to use > struct object_id" which modifies remote-curl.c, so I think it's a > single manual botch. I'm going to rework that patch anyway since > Michael said that he didn't like the idea of parse_oid_hex as it > stands, so it will end up being mostly moot.
In the same email where I made those design suggestions, I also I pointed out a bug in the implementation of parse_oid_hex(). Maybe that is the reason for the test failures. Michael - -- Michael Haggerty mhag...@alum.mit.edu -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlV77aYACgkQwg9mrRwfmAnCyQCeIp9aSOTtQ1ABpiSybcFQFP87 fNwAoLNhQtyFQ2/fqQIvzl1gGEEOlWxa =gI7/ -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
