Matthieu Moy <matthieu....@grenoble-inp.fr> writes: > Remi Galan Alfonso <remi.galan-alfo...@ensimag.grenoble-inp.fr> writes: > > > It is mainly because here the SHA-1 is a long one (40 chars) > > OK, but then the minimum would be to add a comment saying that. > > Now, this makes me wonder why you are doing the check after the sha1 > expansion and not before. Also, when running `git bisect --edit-todo`, I > do get the short sha1. So, there's a piece of code doing what you want > somewhere already. You may want to use it.
Originally I did the whole checking after the expansion because I though that it was a better idea to avoid doing it myself (Comparing the whole SHA-1 instead of partial ones to find missing ones made more sense for me since otherwise I would have to check if one is the prefix of the other or expand to the same size before comparing). However I agree that adding a comment would make things clearer. Will probably do that. Thank you, Rémi -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
