Hi Junio, On 2015-06-25 15:14, Junio C Hamano wrote: > Johannes Schindelin <johannes.schinde...@gmx.de> writes: > >> - I *think* that the current `recreate_opt()` is fine, but if it >> is used more, we will have to quote the arguments to guard against >> spaces and quotes and whatnot > > I admit that that was the reaction I had when I saw it for the first > time, until I realized how it is used. And this one I have to > disagree. recreate-opt is used to munge a single argument, suitable > to be placed into argv[] for execv() like thing---there is no need > for shell quoting there. It is a job for the caller that gets its > result to shell quote if it wants to pass the result to a shell.
Ah yes, no single command-line is constructed from those reconstructed options. So yes, you're right, all is good! Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
