On Fri, Jul 03, 2015 at 10:49:40AM -0700, Junio C Hamano wrote: > Lawrence Siebert <lawrencesieb...@gmail.com> writes: > > > Moving commit counting from rev-list into list-object which is a step > > toward letting git log do counting as well. > > > > Signed-off-by: Lawrence Siebert <lawrencesieb...@gmail.com> > > --- > > No way. Look at the things provided by list-objects.c API. They > are not about formatting outputs. printf() calls do not belong > there.
Moreover, if we are going to provide an abstracted function to show the commit count, we would also need to provide one to _create_ the count. IOW, this get_commit_count, wherever it goes, should be accompanied by the matching code that is put into "show_commit" in patch 2. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
