On Wed, Jun 17, 2015 at 08:36:34AM -0700, Junio C Hamano wrote:
> Kevin Daudt <m...@ikke.info> writes:
> 
> > -           require_clean_work_tree "pull with rebase" "Please commit or 
> > stash them."
> > +           if [ $(git config --bool --get rebase.autostash || echo false) 
> > = false ]
> 
> Style (use of []).

Fixed it.

> 
> Shouldn't you be doing
> 
>       if ...
>       then            
>               on an unborn
>       elif we are not doing autostash
>               require clean work tree
>       fi
> 
> which does not need unnecessarily deep nesting?
> 

You are right, much simpler. New patch is underway.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to