On Tue, Jul 7, 2015 at 9:28 AM, Junio C Hamano <gits...@pobox.com> wrote: > Daniel Barkalow <barka...@iabervon.iabervon.org> writes: > >> On Mon, 6 Jul 2015, Junio C Hamano wrote: >> >>> I cannot seem to be able to find related discussions around that >>> patch, so this is only my guess, but I suspect that this is to >>> discourage people from doing something like: >>> >>> refs/tags/*:refs/tags/foo-* >>> >>> which would open can of worms (e.g. imagine you fetch with that >>> pathspec and then push with refs/tags/*:refs/tags/* back there; >>> would you now get foo-v1.0.0 and foo-foo-v1.0.0 for their v1.0.0 >>> tag?) we'd prefer not having to worry about. >> >> That wouldn't be it, since refs/tags/*:refs/tags/foo/* would have the same >> problem, assuming you didn't set up the push refspec carefully. > > Thanks, I was wondering where you were ;-) Nice to hear from you > from time to time. > >> I think it was mostly that it would be too easy to accidentally do >> something you don't want by having some other character instead of a >> slash, like refs/heads/*:refs/heads-*. > > Hmm, interesting thought. > > But refs/heads/*:refs/heade/* would not be saved, so I do not think > that is it, either.
In this case, I'm more in favor of just allowing these refs because the user already has to manually change the refspecs, which is something many users will never do. I also think that given the above comments, we're not really protecting the user from anything extra... aside from adding more pain because the globs don't work as expected. I did submit a patch (from my @intel.com address since I can't seem to get git-for-windows to send from my home computer) but I am willing to re-work to drop the setting if everyone is ok with that... Thoughts? Regards, Jake -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
