On Sun, Jul 12, 2015 at 2:39 PM, Duy Nguyen <pclo...@gmail.com> wrote: > On Thu, Jun 25, 2015 at 6:43 PM, Karthik Nayak <karthik....@gmail.com> wrote: >> Add support to sort by version using the "v:refname" and >> "version:refname" option. This is achieved by using the >> 'version_cmp()' function as the comparing function for qsort. > > If these v:refname and version:refname are from git-tag, you may want > to see [1]. I would say "version:" or "v:" is in the same class as "-" > (for reverse sort) and they should be parsed in > parse_opt_ref_sorting() instead. They should not be treated as atom > names. By stripping "version:" before pref_ref_filter_atom() is called > in this function, you make "version:" work with all supported atoms. > > [1] http://article.gmane.org/gmane.comp.version-control.git/242446 > -- > Duy
Thanks for this, what you're saying makes sense, will follow. -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
