On Thu, Jul 16, 2015 at 1:06 PM, Junio C Hamano <[email protected]> wrote:
> Dave Borowitz <[email protected]> writes:
>
>> When git-send-pack is exec'ed, as is done by git-remote-http, it does
>> not reread the config, so it does not respect the configured
>> http.signingkey, either from the config file or -c on the command
>> line. Thus it is currently impossible to specify a signing key over
>> HTTP, other than the default one matching the "Name <email>" format in
>> the keyring.
>>
>> This is not an issue for git:// as send-pack is executed directly in
>> the same process that reads the config.
>
> Interesting. I agree that it would be a problem not to be able to
> specify which signing key to use.
>
> Perhaps something like this?
Seems like it should work.
Jonathan had suggested there might be some principled reason why
send-pack does not respect config options, and suggested passing it in
as a flag. But that would be more work, certainly, as it would also
have to get passed through git-remote-http somehow.
> diff --git a/builtin/send-pack.c b/builtin/send-pack.c
> index b564a77..57c3a9c 100644
> --- a/builtin/send-pack.c
> +++ b/builtin/send-pack.c
> @@ -11,6 +11,7 @@
> #include "transport.h"
> #include "version.h"
> #include "sha1-array.h"
> +#include "gpg-interface.h"
>
> static const char send_pack_usage[] =
> "git send-pack [--all | --mirror] [--dry-run] [--force]
> [--receive-pack=<git-receive-pack>] [--verbose] [--thin] [<host>:]<directory>
> [<ref>...]\n"
> @@ -113,6 +114,8 @@ int cmd_send_pack(int argc, const char **argv, const char
> *prefix)
> int from_stdin = 0;
> struct push_cas_option cas = {0};
>
> + git_config(git_gpg_config, NULL);
> +
> argv++;
> for (i = 1; i < argc; i++, argv++) {
> const char *arg = *argv;
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
