On Fri, Jul 17, 2015 at 03:06:57PM +0200, Johannes Schindelin wrote: > > From a quick `git grep '== -1'` and another quick `git grep '< 0'` it appears > to me that we prefer the latter. Maybe you want to adjust it in the patch, > too?
I did the same grep and found lots of examples of both. Many of the "< 0" applied to comparisons with variables and not API calls and many were internal (to git) calls and not POSIX or C library calls so I wasn't convinced to change my initial fix. Having said that and thought about it some more, I think '< 0' is probably better. In POSIX, we shouldn't ever get a negative value which isn't -1, but if we ever do it is probably safer to fail. I'll send and update. Charles. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
