On 17.07.15 19:28, Junio C Hamano wrote: > Eric Sunshine <[email protected]> writes: > >>> Signed-off-by: Beat Bolli <[email protected]> >>> Reviewed-by: Eric Sunshine <[email protected]> >>> Reviewed-by: Johannes Sixt <[email protected]> >> >> You should drop these Reviewed-by: footers, as they imply that the >> code was thoroughly digested and the implementation deemed correct. > > ... and the most importantly, the named people said that themselves. > > I do not think that happened here (yet). > >>> +proc copysummary {} { >>> + global rowmenuid >>> + >>> + set format "%h (\"%s\", %ad)" >>> + set summary [exec git show -s --pretty=format:$format --date=short \ >>> + $rowmenuid] >>> + >>> + clipboard clear >>> + clipboard append $summary >>> +} >>> + > > I think this is a reasonable implementation. The usual "spawning a > process for each commit is too expensive" would not apply, because > it is done on demand only for the single commit that the end-user > specified.
Thanks, Junio! That was my thought as well. So, the question remains now if adding something like --abbrev=$autosellen (maybe only if it's not set to its default value), as Paul suggested, would make sense. Beat -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
