On Tue, Aug 11, 2015 at 11:26 PM, Junio C Hamano <gits...@pobox.com> wrote:
> Karthik Nayak <karthik....@gmail.com> writes:
>
>> -static void print_value(struct atom_value *v, int quote_style)
>> +static void format_quote_value(struct atom_value *v, int quote_style,
>> struct strbuf *output)
>> {
>
> Hmph...
>
>> -static void emit(const char *cp, const char *ep)
>> +static void append_non_atom(const char *cp, const char *ep, struct strbuf
>> *output)
>
> I was tempted to suggest s/non_atom/literal/, but this would do for now...
>
Since I'll be doing a re-roll I could do that.
>> @@ -1262,19 +1257,20 @@ static void emit(const char *cp, const char *ep)
>> void show_ref_array_item(struct ref_array_item *info, const char *format,
>> int quote_style)
>> {
>> const char *cp, *sp, *ep;
>> + struct strbuf output = STRBUF_INIT;
>>
>> for (cp = format; *cp && (sp = find_next(cp)); cp = ep + 1) {
>> struct atom_value *atomv;
>>
>> ep = strchr(sp, ')');
>> if (cp < sp)
>> - emit(cp, sp);
>> + append_non_atom(cp, sp, &output);
>> get_ref_atom_value(info, parse_ref_filter_atom(sp + 2, ep),
>> &atomv);
>> - print_value(atomv, quote_style);
>> + format_quote_value(atomv, quote_style, &output);
>
> If the one to add a literal string (with %hex escaping) is called "append_",
> then this should be called append_quoted_atom() or something, no?
Although it does append like "append_non_atom" this is more of formatting based
on the quote given hence the name.
--
Regards,
Karthik Nayak
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
