On Tue, Aug 11, 2015 at 7:26 PM, Junio C Hamano <gits...@pobox.com> wrote: > Johan Herland <jo...@herland.net> writes: > >> I know that we don't yet have a "proper" place to put remote notes refs, >> but the <ref> in notes.<ref>.merge _must_ be a "local" notes ref (you even >> use the <localref> notation in the documentation below). Thus, I believe >> we can presume that the local notes ref must live under refs/notes/*, >> and hence drop the "refs/notes/" prefix from the config key (just like >> branch.<name>.* can presume that <name> lives under refs/heads/*). > > I am OK going in that direction, as long as we promise that "notes > merge" will forever refuse to work on --notes=$ref where $ref does > not begin with refs/notes/. >
It appears that notes merge already allows operating on refs not in "refs/notes" the way you select what you are merging into is via either --ref or the environment variable.I chose to use the full refs/notes/* format as it was the only one that also supported all layouts. So, should we enforce that default_notes_ref always requires refs inside refs/notes? that doesn't seem a bad idea here. If we only disallow it for merge I think that would be very confusing. Regards, Jake -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
