Thanks for your feedback! I like the “handle big files” plugin kind of idea. However, I wonder if it makes sense to put more and more stuff into git-p4.py (>3000 LOC already). What do you think about splitting git-p4 into multiple files?
Regarding Python 3: Would you drop Python 2 support or do you want to support Python 2/3 in parallel? I would prefer the former… - Lars On 30 Aug 2015, at 10:49, Luke Diamand <l...@diamand.org> wrote: > On 28 August 2015 at 13:24, <larsxschnei...@gmail.com> wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> I am migrating huge Perforce repositories including history to Git. Some of >> them contain large files that would blow up the resulting Git repositories. >> This patch adds an option to store these files in Git LFS [1] on git-p4 >> clone. > > I'm a bit worried by this. LFS isn't the only way to handle large > files in git - there's also git annex (which I've used in a similar > situation) and obviously random homebrew solutions. We're going to end > up with git-p4 sprouting ever increasing numbers of > --use-XXX-if-size-exceeds options. On the other hand, having it > integrated into git-p4 is quite nice as it saves a lot of messing > around. > > Would it be possible as a start to have (within git-p4) a generic > spot-big-files-and-handle-them-differently patch, and a second patch > to add specific LFS support? That then means that other schemes would > be a lot easier to add in future. > > Some other comments inline. > >> >> In order to run the unit tests you need to install the Git LFS extension [2]. >> >> Known limitations: >> The option "use-lfs-if-size-exceeds" looks at the uncompressed file size. >> Sometimes huge XML files are tiny if compressed. I wonder if there is an >> easy way to learn about the size of a file in a git pack file. I assume >> compressing it is the only way to know. >> >> Feedback is highly appreciated. >> >> Thank you, >> Lars >> >> >> [1] https://git-lfs.github.com/ >> [2] https://github.com/github/git-lfs/releases/ >> >> Lars Schneider (1): >> git-p4: add option to store files in Git LFS on import >> >> Documentation/git-p4.txt | 12 ++ >> git-p4.py | 94 ++++++++++++++-- >> t/t9822-git-p4-lfs.sh | 277 >> +++++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 374 insertions(+), 9 deletions(-) >> create mode 100755 t/t9822-git-p4-lfs.sh >> >> -- >> 1.9.5 (Apple Git-50.3) > > Can you switch to a newer git - this one's quite old now so if there > are regressions introduced later, you won't know about them! -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
