On Sat, Oct 3, 2015 at 2:24 AM, Junio C Hamano <gits...@pobox.com> wrote: > Karthik Nayak <karthik....@gmail.com> writes: > >> Implement %(if:equals=<string>) wherein the if condition is only >> satisfied if the value obtained between the %(if:...) and %(then) atom >> is the same as the given '<string>'. >> >> Similarly, implement (if:notequals=<string>) wherein the if condition >> is only satisfied if the value obtained between the %(if:...) and >> %(then) atom is differnt from the given '<string>'. >> >> Add tests and Documentation for the same. >> >> Mentored-by: Christian Couder <christian.cou...@gmail.com> >> Mentored-by: Matthieu Moy <matthieu....@grenoble-inp.fr> >> Signed-off-by: Karthik Nayak <karthik....@gmail.com> >> --- > > The fast that the patch touches only the narrow parts that are > specific to %(if),%(then) and %(else) and does not have to touch any > generic part (other than the populate_value() parser for obvious > reasons) is a good signal that tells us that the basic structure of > the code is very sound. I very much like the direction in which > this series is going ;-) >
Thats nice to hear :) -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
