On 2015-10-15 at 21:21:53 +0200, Matthieu Moy <matthieu....@grenoble-inp.fr> wrote: > Tobias Klauser <tklau...@distanz.ch> writes: > > > + * comments are considered contents to be removed or not. Returns the > > + * number of lines in the resulting buffer. > > We write comments at imperative tone, hence "Return", not "Returns".
The other comments in strbuf.h used "Returns", so I went for it for consistency reasons. But the comment will be obsolete anyhow, as strbuf_stripspace() will not be changed and the functionality implemented in cmd_stripspace() as Junio suggested. > Other than that, I agree with Junio: > > * A preparatory patch introducing parse-options would make the actual > patch much easier to review. Will do. > > * Just running strbuf_stripspace and counting the number of lines in the > result is much simpler. We use stripspace only on user-provided input > which are never really big so maintainability is more important than > performance. Ditto. Thanks -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
