On 2015-10-16 at 18:54:45 +0200, Matthieu Moy <matthieu....@grenoble-inp.fr> wrote: > Tobias Klauser <tklau...@distanz.ch> writes: > > > - Split patch 2/3 into two patches: patch 2/4 switches git stripspace > > to use parse-options and patch 3/4 introduces the new option. > > Much better now. > > > - Implement line counting in cmd_stripbuf() instead of (ab-)using > > strbuf_stripspace() for it. > > Also short and sweet, I like it. > > > - Drop -C short option > > - Correct example command output in documentation. > > - Adjust commit messages to not include links to the wiki, fully > > describe the motivation in the commit message instead. > > Good. > > I read the patches again, and the whole series is now > > Reviewed-by: Matthieu Moy <matthieu....@imag.fr>
Thank you for the review! -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
