Awesome, building with NO_OPENSSL = 1 NO_GETTEXT = 1
produces a working git :-) Cheers, Rafael On 28 October 2015 at 23:37, Filipe Cabecinhas <fil...@gmail.com> wrote: > I did some debugging, and it seems CC_SHA1_Update (used by > write_sha1_file_prepare if APPLE_COMMON_CRYPTO is defined in the Makefile) > takes a uint32_t as a "length" parameter, which explains why it stops > working at 4GiB (UINT_MAX+1). > > In the OS X 10.11 SDK header CommonCrypto/CommonDigest.h, we have: > > typedef uint32_t CC_LONG; /* 32 bit unsigned integer */ > //... > extern int CC_SHA1_Update(CC_SHA1_CTX *c, const void *data, CC_LONG len) > > A possible fix would be to either call SHA1_Update with a maximum of > UINT_MAX, looping if necessary. Or have a compatibility SHA1_Update for OS X > which can handle data longer than UINT_MAX. > > I'm not sure what the git maintainers would prefer. > > Regards, > > Filipe > > On Wed, Oct 28, 2015 at 4:10 PM, Rafael Espíndola > <rafael.espind...@gmail.com> wrote: >> >> I first noticed this with "2.4.9 (Apple Git-60)", but it reproduces >> with git built from 37023ba381b6d251d7140a997b39b566dbc63c42. >> >> Create two files with just 0s: >> >> -rw-r--r-- 1 espindola staff 4294967296 28 Oct 11:09 exactly-4gib >> -rw-r--r-- 1 espindola staff 4294967295 28 Oct 11:09 one-less-than-4gib >> >> >> and run >> >> git init >> git add one-less-than-4gib >> git commit -m bar >> git fsck >> git add exactly-4gib >> git commit -m bar >> git fsck >> >> The first fsck will run with no problems, but the second one fails: >> >> error: packed cfdaf54c9ccfd8f5e4cee562f7d5f92df13d3106 from >> .git/objects/pack/pack-ff08480fd7f767b6bd0aeb559f0f5dea2245b0b3.pack >> is corrupt >> >> Using the very same revision on freebsd doesn't cause any errors. >> >> Cheers, >> Rafael > > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
