Jeff King <p...@peff.net> writes: > On Wed, Nov 11, 2015 at 03:12:05PM +0000, Richard Ipsum wrote: >> >> The aim is not to bless one particular system but to eventually >> provide a common data model that all review systems can share, >> so that it is possible to do distributed reviews with arbitrary UIs >> in a widely compatible way. > > I think that's a laudable goal, but I didn't see any discussion or > documentation of the data model in your patches. Maybe that would be a > good place to start.
Even before doing that it might be a good idea to pick brains of folks who work on Gerrit, who has already done one such data model that may be generic enough to serve as a good starting point. ISTR that they were migrating to a notes based storage to ease federated code review systems? >> If we add git-candidate to contrib then it can act as a reference >> implementation, so that this data model can be validated and tested >> by additional developers. > > That can happen outside of git's contrib/ directory, too. > > I think Michael's "bless" argument applies to the data model, too. Is > your data model a good one? Should other systems adopt it, or is it > still a work in progress? We don't know yet. > > I think I'd rather see it prove itself before entering the git tree, if > only because it doesn't really gain anything by being inside the git > tree. Once upon a time that was a good way to get publicity and easy > hosting, but these days it is easy to find git hosting, and I am not > sure people actually explore contrib/ all that much. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
