On 19 Nov 2015, at 15:35, Jeff King <p...@peff.net> wrote: > On Thu, Nov 19, 2015 at 09:58:11AM +0100, larsxschnei...@gmail.com wrote: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> The tests are currently executed on "Ubuntu 12.04 LTS Server Edition >> 64 bit" and on "OS X Mavericks" using gcc and clang. >> >> Perforce and Git-LFS are installed and therefore available for the >> respective tests. > > My overall impression is that this is a lot more complicated than I was > expecting. Can we start with something simpler to gain experience with > Travis? And then we can add in more complexity later. > > For example: > >> +addons: >> + apt: >> + packages: >> + - language-pack-is > > I doubt most people are running the t0204 right now. Maybe we should > start without it.
Well, I think the entire point of a CI is to run automatically tests that most people are *not* running. Plus I can't recall any problems with language-pack-is and t0204. > >> +env: >> + global: >> + - P4_VERSION="15.1" >> + - GIT_LFS_VERSION="1.0.2" > > I know p4 is your area of interest, but from a project perspective, it > seems like an odd choice for the initial set of tests. See above. Most people do not execute the p4 tests because they don't have p4 installed. Therefore these tests have the highest risk to brake unnoticed. > >> + - DEFAULT_TEST_TARGET=prove >> + - GIT_PROVE_OPTS="--timer --jobs 3" >> + - GIT_TEST_OPTS="--verbose --tee" > > These all make sense, I guess. > >> + - GETTEXT_ISO_LOCALE=YesPlease >> + - GETTEXT_LOCALE=YesPlease > > What are these? I don't think we have any such Makefile knobs. These > look like variables that get used internally by the test suite, but we > shouldn't need to set them. These are used in t020*. I enabled them to run the tests and I haven't seen any problems. However, I am no expert in that area. I'll remove them. > >> + # - GETTEXT_POISON=YesPlease > > I'm assuming the "#" means this is commented out. Can we just drop such > cruft? Yes, for the final submission of course. I just wanted to make it stick out as I wasn't able to run the tests successfully with this flag. I wonder if someone can explain to me how it works. > >> + - GIT_TEST_CHAIN_LINT=YesPlease > > This is the default, and we don't need to specify it. OK > >> + - GIT_TEST_CLONE_2GB=YesPlease > > Is it a good idea to run such an expensive test? Well, it's a CI machine that does not block anyone. I doubt that people run these tests on their local machines for exactly the reason you just described. Therefore I would rather run these tests. > >> + matrix: >> + - >> + # NO_ICONV=YesPlease > > Ditto here on the commenting. OK. Setting NO_ICONV brakes a lot of tests. Do we really "support" that flag? > >> + - > >> + NO_CURL=YesPlease > > So if I understand correctly, the point of this list is to test > alternate configurations. So compiling without curl makes some sense, I > guess. Though mostly it will just shut off a bunch off tests. > >> + NO_D_INO_IN_DIRENT=YesPlease > > But setting platform compat knobs like this seems weird. Nobody sets > this manually. Either your platform has it, or it does not. And we are > already testing on alternate platforms to cover such things. > > If there's a specific config setup of interest, it makes sense to me to > try to increase test coverage there. But it feels like you've just > picked a random laundry list of Makefile knobs and tweaked them, without > any sense of whether they even make sense together, or match the > platform. > > For instance: > >> + NO_STRCASESTR=YesPlease >> + NO_STRLCPY=YesPlease > > I wouldn't not be surprised if these cause problems building on some > platforms that _do_ have these functions. Agreed. As mentioned in gmane/280963 [1] I am no expert in these flags. Should I remove the "NO_*" test configuration all together? [1] http://article.gmane.org/gmane.comp.version-control.git/280963/match=no_ > >> + echo "$(tput setaf 6)Perfoce Server Version$(tput sgr0)"; >> + p4d -V | grep Rev.; >> + echo "$(tput setaf 6)Perfoce Client Version$(tput sgr0)"; >> + p4 -V | grep Rev.; > > s/Perfoce/Perforce/ :) Thanks :) >> +before_script: make configure && ./configure && make --jobs=2 > > Hmm. I wonder if we actually want to use autoconf here at all; most devs > do not use it, and Git should generally compile out of the box based on > config.mak.uname (and if it doesn't, it would be nice to know). > > There may be some optional packages that autoconf helps with, though. Compiling without autoconf works for Linux but not for OS X: https://travis-ci.org/larsxschneider/git/jobs/92222770 > So overall, I dunno. I do not want to create a bunch of work for you in > splitting it up. But I'm hesitant to merge something that has a bunch of > lines that I'm not sure I understand the reasoning for. :-/ I understand. How about this: I create a new roll where I... ... remove the "NO_*" configuration for now. ... remove GETTEXT_* flags ... disable flaky t9810 and t9816 in the Travis CI run ... disable autoconf and try to fix the OS X issue > > I was hoping the first cut could just be telling Travis to run "make > test", without much fanfare beyond that. Maybe that's not realistic. Thanks, Lars -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
