On Sat, Nov 21, 2015 at 11:27 PM, Edmundo Carmona Antoranz <eantor...@gmail.com> wrote: > -static void assign_blame(struct scoreboard *sb, int opt) > +static void assign_blame(struct scoreboard *sb, int opt, int show_progress) > > Would it be better to include show_progress as a binary flag in opt > instead of a separate variable?
What is the point of having 'global' variable and not using it as such? I'm sending a second version of the patch where I'm taking care of most of my previous comments. Let's hope that one holds water. Thanks in advance. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
