On Mon, Nov 23, 2015 at 12:57:12PM +0100, Torsten Bögershausen wrote: > >+ # MacOS 10.7 Lion and higher > > ifeq ($(shell test "`expr "$(uname_R)" : '\([0-9][0-9]*\)\.'`" -ge 11 > > && echo 1),1) > > HAVE_GETDELIM = YesPlease > > endif > >+ # MacOS 10.9 Mavericks and higher > >+ ifeq ($(shell test "`expr "$(uname_R)" : '\([0-9][0-9]*\)\.'`" -ge 13 > >&& echo 1),1) > >+ NO_GETTEXT = YesPlease > >+ endif > > NO_MEMMEM = YesPlease > > USE_ST_TIMESPEC = YesPlease > > HAVE_DEV_TTY = YesPlease > Unless I'm wrong, no Mac OS X had libintl.h, and the "unwritten agreement > (?)" was > that either > a) libintl ist installed in some way (fink, mac ports, brew, other ways) > or > b) people use > NO_GETTEXT=yes make > > Doesn't this patch close the door for b), making it impossible to build Git > against libintl ?
I think the right way to do (b) is: make NO_GETTEXT=Yes which will override anything we do in config.mak.uname (and likewise, anything from autoconf will override it, if we have a test there). Still, it will be a surprise to packagers in (a), who assume that installing libintl and then building git is enough to have gettext support (now they would actively need to override NO_GETTEXT). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
