On 8 December 2015 at 11:41, Sam Hocevar <s...@hocevar.net> wrote: > On Tue, Dec 08, 2015, Lars Schneider wrote: > >> > Would a refactor of lib-git-p4.sh (and probably all git-p4 tests) to >> > support multiple depots be acceptable and/or welcome? I prefer to ask >> > before I dig into the task. >> >> Can you outline your idea a bit? Are you aware of the following way to >> define client specs: [1] ? Would that help? > > That's the idea, but the bug occurs when the client view looks like this: > > //depot/... //client/dir1/... > //depot2/... //client/dir2/... > > And is then cloned with (it is not legal in Perforce to specify //... > directly to grab both depots at once): > > git p4 clone --use-client-spec //depot/... //depot2/... > > Then when a file is modified in dir2/, git p4 submit does not elect it > for the changelist. A file in dir1/ will work fine. > > Unfortunately the current test suite assumes everything is under > //depot/ so in order to write a test for this situation there are a few > things to change in lib-git-p4.sh.
I think the existing structure ought to mostly work, but it might need a bit of tweaking. You would need to create a new depot, but you can do that in your test script. And you would need a client spec that pointed at this depot, but again you can do that in your script with the client_view shell function. I've not tried it myself though, so maybe it's harder than that. Luke > > Regards, > -- > Sam. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
