On Fri, Dec 11, 2015 at 10:26:41AM -0800, Junio C Hamano wrote: > Lars Schneider <larsxschnei...@gmail.com> writes: > > > What do you think about a flag that makes these rewrites case insensitive? > > E.g. with the following config flag: > > > > [url "<actual url base>"] > > insteadOf = <other url base> > > ignorecase = true > > I am with Daniel on this. > > It is perfectly fine to consider these two equivalent. > > git clone https://github.com/git/git (canonical one) > git clone https://GitHub.com/git/git (host part in funny case) > > In fact, I think we should do this without any additional > configuration variable. > > On the other hand, these two MUST be treated as different by > default: > > git clone https://github.com/GIT/GIT (differences outside host part) > git clone g...@github.com:GIT/GIT (differences outside host part)
I haven't looked, but the code in urlmatch.c probably gets all of this right already. It was written much later than the insteadOf code, as it was part of the http.$url.* matching, and it may be reasonable to simply teach the insteadOf code to use it. OTOH, it may need tweaked because I'm not sure how it would handle non-URLs like the "host:path" ssh form. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
