On Fri, Dec 18, 2015 at 06:06:37PM -0600, Doug Kelly wrote: > Corrects the issues found in review by Peff, including simplifying > the logic in report_helper(). bits_to_msg() would've been an alternate > solution to that change, however it'll get called by > real_report_garbage(), so there's no need to call it twice, especially > when the check we need within report_helper().
OK. The new logic in 1/3 looks fine to me. > I think checking for seen_bits == 0 would be future-proofing should we > arrive at a file bit not otherwise match it (i.e. file.foo and > file.bar, but nothing else would cause seen_bits to be zero, but if > that's the case, we wouldn't have PACKDIR_FILE_IDX or > PACKDIR_FILE_PACK set, either, and the second half would also match. Yeah, I think this is sound. I left a few comments on 3/3. I don't think it's _wrong_, but I think we can be a bit more thorough (and IMHO, a little more maintainable, but others might disagree). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
