Duy Nguyen <pclo...@gmail.com> writes: > (I'm joining the newer thread [1] back to this one, thanks for > reminding me about this) > > [1] http://thread.gmane.org/gmane.comp.version-control.git/282771 > > On Tue, Sep 22, 2015 at 2:40 AM, Junio C Hamano <gits...@pobox.com> wrote: >> Josef Kufner <jo...@kufner.cz> writes: >> >>> Pass graph width to pretty formatting, so N in '%>|(N)' includes columns >>> consumed by graph rendered when --graph option is in use. >>> >>> Example: >>> git log --all --graph --pretty='format: [%>|(20)%h] %ar%d' >>> >>> All commit hashes should be aligned at 20th column from edge of the >>> terminal, not from the edge of the graph. >>> >>> Signed-off-by: Josef Kufner <jo...@kufner.cz> >>> --- >> >> [CC'ed Duy for ideas, as the "%>|(ALIGN)" thing is his invention] >> ... >> >> I have a suspicion that 50% of the users would appreciate this >> change, and the remainder of the users see this break their >> expectation. To avoid such a regression, we may be better off if we >> introduced a new alignment operator that is different from '%>|(N)' >> so that this new behaviour is available to those who want to use it, >> without negatively affecting existing uses. > > I tend to agree with Josef. >|(N) is about columns relative to the > left edge of the screen. You can already use >(N) to be relative to > the left edge of the space given to the commit.
OK. I didn't check if >(N) with that old patch still behaves that way, but if that is sensible, then it is not breaking anything, so it may be a good idea to salvage it. I dunno. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
