On Tue, Dec 29, 2015 at 8:55 AM, Duy Nguyen <pclo...@gmail.com> wrote: > On Mon, Dec 28, 2015 at 1:22 PM, Eric Sunshine <sunsh...@sunshineco.com> > wrote: >> On Sun, Dec 27, 2015 at 10:43:16AM +0700, Nguyễn Thái Ngọc Duy wrote: >>> If you move a linked working tree to another file system, or >>> -within a file system that does not support hard links, you need to run >>> -at least one git command inside the linked working tree >>> -(e.g. `git status`) in order to update its administrative files in the >>> -repository so that they do not get automatically pruned. >>> +within a file system that does not support hard links, you need to update >> >> Hmm, is this "hard links" feature implemented? If not, then this >> documentation is a bit outdated. > > The prune logic is there. But this hard link is not created by > 'worktree add'. I think calling link() was done at some point but then > it got dropped. Ah found it, it wasn't a big "no" so maybe we can > revive it at some point. > > http://article.gmane.org/gmane.comp.version-control.git/243475
Hmm, yes... >>> +$GIT_DIR/worktrees/<id>/gitdir so that they do not get automatically >>> pruned. >> >> Following the example of af189b4 (Documentation/git-worktree: split >> technical info from general description, 2015-07-06), it might be a >> good idea to keep this high-level overview free of such low-level >> details and instead mention $GIT_DIR/worktrees/<id>/gitdir in the >> "DETAILS" section. >> >> Perhaps something like this, on top of your patch (assuming that the >> "hard links" feature is not implemented): > > Looks good. > > How about something like this at the end of the last new paragraph? > "alternatively if your file system supports hard link and the worktree > and $GIT_DIR are on the same file system, you can create a hard link > named "link" back to the .git file. See gitrepository-layout.txt for > more information". That makes sense, however... If I understand correctly, while it's true that the 'link' file will inhibit pruning, don't we still have the problem that "git worktree list" will show an outdated path if the user fails to update 'gitdir'? And doesn't the "branch already checked out in some other worktree" interrogation also depend upon 'gitdir' being up-to-date? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
