On Thu, Dec 31, 2015 at 01:21:42AM -0500, Eric Sunshine wrote: > > - item->string[len] = '\0'; > > + len = strlen(item->string); > > + while (len && item->string[len - 1] == '\n') > > + item->string[--len] = '\0'; > > Not a strong objection, but this implementation may make the reader > wonder why NUL needs to be assigned to all "stripped" characters. I'd > have expected to see: > > len = strlen(item->string); > while (len && item->string[len - 1] == '\n') > len--; > item->string[len] = '\0'; > > which indicates clearly that this is a simple truncation rather than > some odd NUL-fill operation, and is slightly more easy to reason about > since it doesn't involve a pre-decrement as an array subscript.
Hmm. I consider the "write NULs backward" strategy to be pretty idiomatic (you can find several similar ones grepping for `\[--` in the git codebase). But that may just be me (I didn't look, but it's possible I wrote the other ones, too :) ). I don't have a strong preference, though. What you've written is quite readable. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
