On Sun, Jan 31, 2016 at 11:12 PM, Karthik Nayak <karthik....@gmail.com> wrote: > @@ -138,10 +140,9 @@ int parse_ref_filter_atom(const char *atom, const char > *ep) > * shouldn't be used for checking against the valid_atom > * table. > */ > - const char *formatp = strchr(sp, ':'); > - if (!formatp || ep < formatp) > - formatp = ep; > - if (len == formatp - sp && !memcmp(valid_atom[i].name, sp, > len)) > + arg = memchr(sp, ':', ep - sp); > + if ((!arg || len == arg - sp) && > + !memcmp(valid_atom[i].name, sp, len)) > break; > } >
Also having a look at this, this breaks the previous error checking we had at parse_ref_filter_atom(). e.g: git for-each-ref --format="%(refnameboo)" would not throw an error. I think the code needs to be changed to: - if ((!arg || len == arg - sp) && + if ((arg || len == ep - sp) && + (!arg || len == arg - sp) && -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
