On Mon, 2016-02-08 at 14:22 -0800, Junio C Hamano wrote: > Matt McCutchen <m...@mattmccutchen.net> writes: > > > I found no evidence of such behavior in the source code. > > > > Signed-off-by: Matt McCutchen <m...@mattmccutchen.net> > > --- > > That was added last year at bcd57cb9 (Documentation/git-clean.txt: > document that -f may need to be given twice, 2015-02-26). It would > be better to know what got changed since then--that is, was the > additional text unnecessary even back then, or we made changes to > the system since then and forgot to remove the added text. > > Mikko, is this need to give -f twice still the case?
I know you probably want confirmation from Mikko, but I'll offer my understanding. There were two statements added in bcd57cb9: 1. -f may need to be given twice to delete nested worktrees and embedded repositories. This is still true. 2. Deletion of submodule repositories under .git/modules is conditional on -f being given twice. AFAICT, this was wrong even back then: "git clean" has never deleted such repositories under any conditions. My patch is only removing #2. Matt -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
