On Mon, Feb 15, 2016 at 02:18:18PM -0800, Junio C Hamano wrote: > larsxschnei...@gmail.com writes: > > > +test_expect_success 'set up custom config file' ' > > + CUSTOM_CONFIG_FILE=$(printf "file\twith\ttabs.conf") && > > + cat >"$CUSTOM_CONFIG_FILE" <<-\EOF > > + [user] > > + custom = true > > + EOF > > +' > > + > > +test_expect_success '--show-origin escape special file name characters' ' > > + cat >expect <<-\EOF && > > + file:"file\twith\ttabs.conf" user.custom=true > > + EOF > > + git config --file "$CUSTOM_CONFIG_FILE" --show-origin --list >output && > > + test_cmp expect output > > +' > > Do we really need to use a file with such a name? > > An existing test t3300 tells me that a test that uses a path with a > tab needs to be skipped on FAT/NTFS. If your goal is to make sure > dquote is exercised, can't we just do with a path with a SP in it or > something?
It has to trigger quote_c_style(). You can see the complete set of quoted characters in quote.c:sq_lookup, but space is not one of them. Probably double-quote or backslash is the best bet, as the rest are all control characters. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
