Junio C Hamano <gits...@pobox.com> writes: > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Use the config type to print more detailed error messages that inform >> the user about the origin of a config error (file, stdin, blob). > > "type" is too broad a word in the context of configuration file, and > does not help readers as a variable or a field name in a structure. > You are not talking about "this is a binary typed variable", for > example. > > If showing the origin is useful to the user, that origin should be > called origin, not type, I would think.
You seem to use in 3/3 "origin type", and I think that is a sensible phrasing. Renaming 'type' to 'origin' in this patch would not be a good idea, but renaming it to 'origin_type' would be a great thing to do. In the context of configuration parsing, 'origin' would be like "file called .git/config", "standard input", "command line's 3rd argument", etc., i.e. for some origin types, it would consist of <origin_type=file, origin_value=.git/config> pair, while some other origin type (e.g. "standard input") there is no need for an "origin_value" that further qualifies the origin. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
