On Thu, Feb 18, 2016 at 3:49 AM, Junio C Hamano <gits...@pobox.com> wrote: > Jeff King <p...@peff.net> writes: > >> On Wed, Feb 17, 2016 at 05:11:50PM -0500, Eric Sunshine wrote: >> >>> On Wed, Feb 17, 2016 at 1:06 PM, Karthik Nayak <karthik....@gmail.com> >>> wrote: >>> > From: Jeff King <p...@peff.net> >>> > >>> > We don't do any post-processing on the resulting strbufs, so it is >>> > simpler to just use string_list_split, which takes care of removing >>> > the delimiter for us. >>> > >>> > Written-by: Jeff King <p...@peff.net> >>> >>> Perhaps Peff can give his sign-off... >> >> Ah, right. I usually sign-off when sending to the list, so the version >> he pulled from GitHub didn't have it. >> >> Definitely: >> >> Signed-off-by: Jeff King <p...@peff.net> >> >> And I don't think "Written-by" was doing much here, anyway; I am already >> the author by the From header at the top. :) > > ;-). > > So, is everybody happy with this round? > > With another series on top for the "conditional" stuff, I guess we > are ready to do the formatting for "git branch --list", which would > be a big step forward. > > Thanks.
Yes, I'll be sending that soon :D > Yes, v6 looks good to me and is: > > Reviewed-by: Eric Sunshine <sunsh...@sunshineco.com> > I have not looked with nearly as close an eye as Eric, but I did not see > anything objectionable (and I trust the reviews that have led us up to > v6 in the first place). > > Thanks, Karthik, for your continued work on this (and to reviewers, of > course :) ). > > -Peff Thanks to everyone who helped, especially reviewers for going through such long patch series. -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
