Junio C Hamano <gits...@pobox.com> writes:
> Johannes Schindelin <johannes.schinde...@gmx.de> writes:
>
>> diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh
>> index 91235b7..f62409e 100755
>> --- a/t/t1308-config-set.sh
>> +++ b/t/t1308-config-set.sh
>> @@ -218,4 +218,13 @@ test_expect_success 'check line errors for malformed
>> values' '
>> test_i18ngrep "fatal: .*alias\.br.*\.git/config.*line 2" result
>> '
>>
>> +test_expect_success 'error on modifying repo config without repo' '
>> + mkdir no-repo &&
>> + GIT_CEILING_DIRECTORIES=$(pwd) &&
>> + export GIT_CEILING_DIRECTORIES &&
>> + cd no-repo &&
>> + test_must_fail git config a.b c 2>err &&
>> + grep "not in a git directory" err
>> +'
>> +
>> test_done
>
> Please make it a habit to run tests that go up/down in the hierarchy
> in a subshell. It is not a good excuse that this new test happens
> to be at the end _right now_.
I'd squash this in.
Thanks.
t/t1308-config-set.sh | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh
index f62409e..9863d0d 100755
--- a/t/t1308-config-set.sh
+++ b/t/t1308-config-set.sh
@@ -220,11 +220,13 @@ test_expect_success 'check line errors for malformed
values' '
test_expect_success 'error on modifying repo config without repo' '
mkdir no-repo &&
- GIT_CEILING_DIRECTORIES=$(pwd) &&
- export GIT_CEILING_DIRECTORIES &&
- cd no-repo &&
- test_must_fail git config a.b c 2>err &&
- grep "not in a git directory" err
+ (
+ GIT_CEILING_DIRECTORIES=$(pwd) &&
+ export GIT_CEILING_DIRECTORIES &&
+ cd no-repo &&
+ test_must_fail git config a.b c 2>err &&
+ grep "not in a git directory" err
+ )
'
test_done
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
