On Wed, Feb 24, 2016 at 10:19:05PM -0800, Jacob Keller wrote: > >> + /* combined all the values before we quote them */ > > > > Comment repeats what the code already says, thus not terribly useful. > > > > Also: s/combined/combine/ > > > I tend to make comments like this when I change the obvious way it was > done, I commented this because I based it on a scratch patch from Jeff > that didn't have them put together before quoting.
That's a good point. The _what_ is not interesting here, but the _why_ might be. Namely that we must quote the whole thing as a unit, or the parser on the receiving end will not be able to read it. I'd also be amenable to relaxing the parser (which is as strict as it is only out of laziness, and the fact that it was reading the output only of its nearby generator function). But I can understand if you don't feel like digging into that. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
