On 28 February 2016 at 10:25,  <larsxschnei...@gmail.com> wrote:
> From: Lars Schneider <lars.schnei...@autodesk.com>
>
> Map a P4 user to a specific name and email address in Git with the
> "git-p4.mapUser" config. The config value must be a string adhering
> to the format "p4user -> First Lastname <em...@address.com>".

Seems generally fine. I agree with Eric's comments about the "->"
format. One comment below:

> +test_expect_success 'Clone repo root path with all history' '
> +       client_view "//depot/... //client/..." &&
> +       test_when_finished cleanup_git &&
> +       (
> +               cd "$git" &&
> +               git init . &&
> +               git config --add git-p4.mapUser "mmax -> Max Mustermann 
> <m...@muster.com>"  &&
> +               git config --add git-p4.mapUser "mo -> Moritz Untreu 
> <mor...@untreu.com>" &&

Probably better to use more innocuous names. I'm not sure who these
people are, but they might not appreciate being recorded forver in a
git-p4 test script.

Luke
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to