Christian Couder <christian.cou...@gmail.com> writes: > One point I'd especially welcome feedback about is the fact that there > are many boolean options that are using OPT_BOOL(...), so they use an > int. And there are a few others that are using OPT_BIT(...), so they > use just a bit. I wonder if it is worth it to try to be consistent, > and maybe also to try to save some memory. > > Related to this, some of the variables for these options have not been > moved into the "apply_state" structure, because they are not global to > the file, but maybe for consistency they should be.
These might be worthy clean-ups but that is only if they are done after we make sure conversion proper is done faithfully to the original, i.e. without introducing unnecessary bugs. I'd advise against doing them before the libification is done. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
