On Tue, Mar 15, 2016 at 11:58 AM, Eric Sunshine <[email protected]> wrote: > On Tue, Mar 15, 2016 at 2:25 PM, Alexander Kuleshov > <[email protected]> wrote: >> submodule-config: use hashmap_iter_init() > > Did you mean s/init/first/ ? > >> from the <hashmap.h> for simplification. > > Sentence fragment... > > Missing sign-off. > >> --- >> diff --git a/submodule-config.c b/submodule-config.c >> index b82d1fb..8ac5031 100644 >> --- a/submodule-config.c >> +++ b/submodule-config.c >> @@ -405,8 +405,7 @@ static const struct submodule *config_from(struct >> submodule_cache *cache, >> struct hashmap_iter iter; >> struct submodule_entry *entry; >> >> - hashmap_iter_init(&cache->for_name, &iter); >> - entry = hashmap_iter_next(&iter); >> + entry = hashmap_iter_first(&cache->for_name, &iter);
The change looks correct to me. But as Eric said, the commit message needs work and a sign off. With that, Reviewed-by: Stefan Beller <[email protected]> Thanks, Stefan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
