On Tue, Mar 15, 2016 at 5:10 AM, Junio C Hamano <gits...@pobox.com> wrote: > Paul Tan <pyoka...@gmail.com> writes: > >> In the upcoming git-rebase to C rewrite, it is a common operation to >> refresh the index and write the resulting index. >> >> builtin/am.c already implements refresh_and_write_cache(), which is what >> we want. Move it to rebase-common.c, so that it can be shared with all >> the rebase backends, including git-am. > > Your rebase-am might be one of the rebase backends, but git-am is > not, so it is misleading to count it among "all the rebase > backends". > > I would think that a better home for refresh_and_write_index() is > right next to write_locked_index(), with #define in cache.h for > refresh_and_write_cache(), just like others.
Okay, thanks for suggesting a better location. Regards, Paul -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
