Quoting Pranit Bauva <[email protected]>:

On Sun, Mar 27, 2016 at 5:21 PM, SZEDER Gábor <[email protected]> wrote:
+test_expect_success 'commit.verbose true and --no-verbose' '
+     git -c commit.verbose=true commit --amend --no-verbose &&
+     ! test -s out

Please use the test_must_be_empty helper instead, because it has a
nice, human-readable name and it complains with a helpful error
message if something goes wrong, whereas 'test -s' just fails
silently.

Thanks for pointing it out. I was unsure whether 'test -s' is a good
choice but used it since I did not know any other alternative.

t/test-lib-functions.sh contains all our test helpers functions, that's
where you can look for a suitable helper, should it be necessary.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to