On 2016-03-29 15.31, Duy Nguyen wrote: > On Tue, Mar 29, 2016 at 8:28 PM, Duy Nguyen <pclo...@gmail.com> wrote: >> On Tue, Mar 29, 2016 at 8:25 PM, <tbo...@web.de> wrote: >>> From: Torsten Bögershausen <tbo...@web.de> >>> >>> Factor out the retrival of the sha1 for a given path in >>> read_blob_data_from_index() into the function get_sha1_from_index(). >> >> Getting _sha1_ from index is one function call and a memory >> dereference or two. I think you mean get sha1 _file_ (or data) from >> index. Maybe put either word in the function name. > > Oops, shouldn't have trusted that function name in the @@ line. No > what you write in the commit message matches the patch. Sorry for the > noise. > Thanks for the review. It feels that the naming isn't ideal, let's see if we can find a better function name. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
- Re: [PATCH 1/3] git reset --hard gives clean working... Junio C Hamano
- Re: [PATCH 1/3] git reset --hard gives clean wo... Junio C Hamano
- Re: [PATCH 1/3] git reset --hard gives clea... Junio C Hamano
- Re: [PATCH 1/3] git reset --hard gives ... Torsten Bögershausen
- Re: [PATCH 1/3] git reset --hard gi... Junio C Hamano
- [PATCH v1 3/7] Allow core.autocrlf=... tboegi
- [PATCH v1 2/7] convert.c: stream an... tboegi
- [PATCH v1 1/7] Make it possible to ... tboegi
- Re: [PATCH v1 1/7] Make it possible... Duy Nguyen
- Re: [PATCH v1 1/7] Make it possible... Duy Nguyen
- Re: [PATCH v1 1/7] Make it possible... Torsten Bögershausen
- Re: [PATCH v1 1/7] Make it possible... Eric Sunshine
- [PATCH v1 4/7] t0027: TC for combin... tboegi
- [PATCH v1 5/7] CRLF: unify the &quo... tboegi
- Re: [PATCH v1 5/7] CRLF: unify the ... Eric Sunshine
- [PATCH v1 6/7] correct blame for fi... tboegi
- Re: [PATCH v1 6/7] correct blame fo... Junio C Hamano
- Re: [PATCH v1 6/7] correct blame fo... Torsten Bögershausen
- Re: [PATCH v1 6/7] correct blame fo... Junio C Hamano
- Re: [PATCH v1 6/7] correct blame fo... Junio C Hamano
- Re: [PATCH v1 6/7] correct blame fo... Junio C Hamano