On Wed, Mar 30, 2016 at 1:05 PM, Stefan Beller <sbel...@google.com> wrote: > `split` is of type `struct strbuf **`, which we have a dedicated free > function for, which takes care of freeing all related memory.
I think it's important to explain that 'split' and each split[] element were being leaked (despite the existing strbuf_release()) as justification for why this change is beneficial. > Helped-by: Eric Sunshine <sunsh...@sunshineco.com> > Signed-off-by: Stefan Beller <sbel...@google.com> > --- > wt-status.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/wt-status.c b/wt-status.c > index ef74864..1ea2ebe 100644 > --- a/wt-status.c > +++ b/wt-status.c > @@ -1063,9 +1063,7 @@ static void abbrev_sha1_in_line(struct strbuf *line) > strbuf_addf(line, "%s", split[i]->buf); > } > } > - for (i = 0; split[i]; i++) > - strbuf_release(split[i]); > - > + strbuf_list_free(split); > } -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
