On Thu, Mar 31, 2016 at 11:49 PM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> Current implementation of parse-options.c treats OPT__QUIET() as integer >> and not boolean and thus it is more appropriate to print it as integer >> to avoid confusion. >> >> While at it, fix some style issues. > > I counted the changes in t0040 and you have _more_ style fixes than > the real change. That is not "while at it". > > While I welcome the style fix, it is better done as a preparatory > clean-up step before the real change.
Okay. I thought this was a minor change so I squashed it together. I will separate it though. > Missing sign-off. Will include this >> -cat > typo.err << EOF >> +cat >typo.err <<EOF >> error: did you mean \`--boolean\` (with two dashes ?) >> EOF > > If your "style cleanup" patch were separate, you could fix this (and > other that have backslash escape inside the here-document) further > to something like this: > > cat >type.err <<\EOF > error: did you mean `--boolean` (with two dashes ?) > EOF > > Thanks. Will include this. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
