On Mon, Apr 11, 2016 at 07:04:23PM +0000, miwilli...@google.com wrote: > From 7201fe08ede76e502211a781250c9a0b702a78b2 Mon Sep 17 00:00:00 2001 > From: Mike Williams <miwilli...@google.com> > Date: Mon, 11 Apr 2016 14:18:39 -0400 > Subject: [PATCH 1/1] wt-status: Remove '!!' from > wt_status_collect_changed_cb
These bits (minus the initial "From ..." line) should go into your actual email headers. As it is, your email has no subject line. > The wt_status_collect_changed_cb function uses an extraneous double > negation (!!) when determining whether or not a submodule has new > commits. > [...] > - d->new_submodule_commits = !!hashcmp(p->one->sha1, > p->two->sha1); > + d->new_submodule_commits = hashcmp(p->one->sha1, > p->two->sha1); It's not extraneous. hashcmp() returns 0 for equality, but an arbitrary positive or negative value depending on how the two arguments differ. The assigned "new_submodule_commits" is a bitfield of size 1. So the "!!" is normalizing the value into "0" or "1". -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
