On Sun, Apr 17, 2016 at 2:38 PM, Santiago Torres <santi...@nyu.edu> wrote: > On Sun, Apr 17, 2016 at 02:19:00PM -0400, Eric Sunshine wrote: >> Junio already made this correction and others in the three patches he >> queued on his 'pu' branch. It's possible that he also made other >> tweaks not mentioned in the reviews, so it's a good idea to compare >> what he queued against what you plan to send for the re-roll to ensure >> that nothing is missed. Thanks. > > Oh, I'm looking at the patches in pu, I didn't know they were there yet. > Thanks for the heads up. > > Also, would it make sense to copy the commit messages as they are on the pu > branch? for consistency? Or should ommit those three patches and work > on 4+ for the re-roll instead?
I just re-read the commit messages as Junio queued them on 'pu', and they are all good, so yes it would be plenty sensible to copy the commit messages from the three queued patches (along with whatever other tweaks he made). Since the patches are only in 'pu' (but not in 'next'), when you re-roll, resubmit the entire series, not just the patches he didn't queue. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
