Nguyễn Thái Ngọc Duy <[email protected]> writes: > First cut. I need opinions on 05/07, which converts > wt_status_get_state() to support selecting any worktree. I'm not super > happy with leaving "TODO: not supported yet" comments, even though > strictly speaking this series does not need it.
It is a reasonable idea to hook this to wt_status_get_state(), I would say. > Another option is leave wt_status_get_state() alone, factor out the > rebase-detection code and use that for worktree/checkout. We save a > few syscalls this way too. > > Comments? > > [01/07] path.c: add git_common_path() and strbuf_git_common_path() > [02/07] worktree.c: store "id" instead of "git_dir" > [03/07] path.c: refactor and add worktree_git_path() > [04/07] worktree.c: add worktree_git_path_..._head() I actually wondered how ky/branch-[dm]-worktree topics to avoid "branch -d" and "branch -m" from removing or renaming a branch that is checked out in other worktrees from screwing them up. There may be a missed opportunity to clean them up with using these? > [05/07] wt-status.c: make wt_status_get_state() support worktree > [06/07] worktree.c: avoid referencing to worktrees[i] multiple times > [07/07] checkout: prevent checking out a branch being rebased in another > worktree > > Total 6 files changed, 167 insertions(+), 38 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
