On Mon, May 2, 2016 at 5:59 PM, Junio C Hamano <gits...@pobox.com> wrote: > ba3c69a9 (commit: teach --gpg-sign option, 2011-10-05) introduced a > "signed commit" by teaching --[no-gpg-sign option and commit.gpgsign
s/\[no/[no]/ (ditto in the "simpler" patch) > configuration variable to various commands that create commits. > > Teaching these to "git commit" and "git merge", both of which are > end-user facing Porcelain commands, was perfectly fine. Allowing > the plumbing "git commit-tree" to suddenly change the behaviour to > surprise the scripts by paying attention to commit.gpgsign was not. > > Among the in-tree scripts, filter-branch, quiltimport, rebase and > stash are the commands that run "commit-tree". If any of these > wants to allow users to always sign every single commit, they should > offer their own configuration (e.g. "filterBranch..gpgsign") with an > option to disable (e.g. "git filter-branch --no-gpgsign"). > > Ignoring commit.gpgsign option _obviously_ breaks the backward > compatibility, and I seriously doubt anybody sane is depending on > this misfeature that commit-tree blindly follows commit.gpgsign in > any third-party script that calls it, but following the "be careful > when removing (mis)features" tradition, let's give these scripts an > escape hatch. Passing the new --use-commit-gpgsign-config option to s/to$// > makes it pay attention to the commit.gpgsign configuration again. > > Signed-off-by: Junio C Hamano <gits...@pobox.com> -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
