Jeff King <[email protected]> writes: > On Tue, May 03, 2016 at 11:54:32AM -0700, Stefan Beller wrote: > >> As the test runs `chmod 0` on a file, we don't want to run that test >> as root. > > This somehow misses the root (no pun intended) of the issue, to me. > Perhaps: > > We `chmod 0` a file and test a case where git is unable to read it. > If the test is run as root, the permissions are ignored, and our > simulated read failure does not happen. > > The patch itself looks obviously correct. :) > > -Peff
By the way, it is easy to make a mistake like this, not to notice it during a review, and to leave it unnoticed for a long time, especially because I do not think anybody active in the development community runs tests as 'root'. Perhaps in a future update, Travis should learn a step to catch breakages like like this. Or perhaps it is not worth the effort? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
