On Thu, May 05, 2016 at 05:23:51PM -0700, Stefan Beller wrote: > >> -/* > >> - * This function is intended as a callback for use with > >> - * git_config_from_parameters(). It ignores any config options which > >> - * are not suitable for passing along to a submodule, and accumulates the > >> rest > >> - * in "data", which must be a pointer to a strbuf. The end result can > >> - * be put into $GIT_CONFIG_PARAMETERS for passing to a sub-process. > >> - */ > >> -int sanitize_submodule_config(const char *var, const char *value, void > >> *data); > >> - > >> /* > >> * Prepare the "env_array" parameter of a "struct child_process" for > >> executing > >> * a submodule by clearing any repo-specific envirionment variables, but > >> - * retaining any config approved by sanitize_submodule_config(). > >> + * retaining any config in the environment. > >> */ > >> void prepare_submodule_repo_env(struct argv_array *out); > >> > >> > >> -Peff > > > > Hmph, Stefan, do you want to keep this (if you want to resurrect the > > function in some future, for example)? > > IMHO it is easier to revert or rewrite than to carry unused code? > Unused code is not tested and untested code is broken code. > And relying on broken code in the future will guarantee bugs. > (Sure new code may also have bugs, but I just think that bugs > in newly written code can be fixed easier) > > I would prefer to get rid of it, i.e. taking that patch.
Keep in mind this squash is just dropping the _declaration_. The code itself was dropped in the earlier patch. (And I agree there isn't a good reason to keep it when we can easily "git revert" later). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
