Stefan Beller <sbel...@google.com> writes:
>> + if (!item)
>> + ; /* not among entries being checked */
>> + else {
>> + if (strcmp((const char *)item->util, buf.buf)) {
>> + printf("expected '%s', got '%s'\n",
>> + (char *)item->util, buf.buf);
>> + *status = 1;
>> + }
>> + }
>> + }
>> + strbuf_reset(&buf);
>
> strbuf_release ?
Thanks for spotting a leak.
I originally had the buf as static, as all generated strings are
short and of similar length, in an attempt to reuse the already
allocated storage instead of allocating it from scratch every call.
>>
>> return 0;
>
> return ret; ? Otherwise `ret` is unused.
This, too. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
