Joey Hess <i...@joeyh.name> writes: > I'm using smudge/clean filters in git-annex now, and it's not been an > entirely smooth fit between the interface and what git-annex wants > to do. > > The clean filter has to consume the whole file content on stdin; > not reading it all will make git think the clean filter failed. > But, git-annex often doesn't need to read the whole content of a > work-tree file in order to clean it. > > The smudge filter has to output the whole file content to stdout. But > git-annex often has the file's content on disk already, and could just > move it into place in the working tree. This would save CPU and IO and > often disk space too. But the smudge interface doesn't let git-annex use > the efficient approach.
The smudge happens to be the last to run, so it is quite true that it can say "Hey Git, I've written it out already". I didn't check all codepaths to ensure that we won't need the smudged result in core at all, but I am guessing you did so before making this proposal, so in that case I would say this sounds fine. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
